[GCP-8646] BigQuery: Add support to Dataset for project_ids with org prefix. #14
Conversation
added support to Dataset for project_ids with org prefix
updated tests to check dataset chgs
emar-kar
changed the title
emar-kar
changed the title
| 'e.g. "project.dataset_id", got {}'.format(dataset_id) | ||
| 'e.g. "project.dataset_id" or, single prefix usage ' | ||
| 'is also permitted e.g. "prefix:project.dataset_id" ' | ||
| "got {}".format(dataset_id) |
There was a problem hiding this comment.
The singe- or double-quote usage should be consistent among multiple lines. I'd suggest using single quotes if the contents must contain double ones. Also, I believe there should be commas before each of the e.g. abbreviations.
There was a problem hiding this comment.
I checked the usage of quotes and didn't notice any discrepancy. As I see, I added single-quotes on the lines where the contents include double-quotes. Or, did I misunderstand you?
Regarding e.g., I checked some English grammar sources and it is written there that it should be enclosed with commas both sides.
There was a problem hiding this comment.
Having both, single and double quotes enclosing different lines of the same comment is syntactically right, but having a single quote type looks more intuitive and visually pleasing:
'When default_project is not set, dataset_id must be a '
'fully-qualified dataset ID in standard SQL format, '
'e.g., "project.dataset_id" or, single prefix usage '
'is also permitted, e.g., "prefix:project.dataset_id" '
'got {}'.format(dataset_id)
Regarding e.g., commas on both sides is even better.
mf2199
changed the title
| 'e.g. "project.dataset_id", got {}'.format(dataset_id) | ||
| 'e.g. "project.dataset_id" or, single prefix usage ' | ||
| 'is also permitted e.g. "prefix:project.dataset_id" ' | ||
| "got {}".format(dataset_id) |
There was a problem hiding this comment.
Having both, single and double quotes enclosing different lines of the same comment is syntactically right, but having a single quote type looks more intuitive and visually pleasing:
'When default_project is not set, dataset_id must be a '
'fully-qualified dataset ID in standard SQL format, '
'e.g., "project.dataset_id" or, single prefix usage '
'is also permitted, e.g., "prefix:project.dataset_id" '
'got {}'.format(dataset_id)
Regarding e.g., commas on both sides is even better.
Applying requested chgs. // Removed description for 'single prefix'.
Complete template change.
minor corrections
pattern rewrote with the '[^.]' and .VERBOSE (due to blacken session) added test to check extra parts within the string with the prefix reconf prefix in an existed test
Addresses #8646
Some nox tests/unittests/pytests failed on my PC. According to the trace its not the fault of my chgs.
I decided to use regular expressions to resolve the issue, but I'm still thinking about over ways to do it. Appreciate any help here.